Skip to content

Let the labels to be in new line, no padding left #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyphan1 merged 1 commit into from
May 14, 2025
Merged

Let the labels to be in new line, no padding left #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/campaign/UpcomingCampaigns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ export default function UpcomingCampaigns() {
<h4 className="font-medium text-primary text-sm">
{editedCampaign.title || 'Untitled Campaign'}
</h4>
<div className="flex items-center text-xs text-muted-foreground mt-1">
<div className="flex items-center text-xs text-muted-foreground mt-1 flex-wrap">
<Calendar className="h-3 w-3 mr-1" />
{format(
new Date(editedCampaign.runAt * 1000),
Expand All @@ -438,7 +438,7 @@ export default function UpcomingCampaigns() {
{editedCampaign.campaignLabelNames && editedCampaign.campaignLabelNames.length > 0 && (
<div className="w-full mt-1 flex">
{editedCampaign.campaignLabelNames.map((labelName, idx) => (
<span key={idx} className="mr-1 mb-1 inline-flex items-center bg-muted rounded px-1.5 py-0.5 text-xs">
<span key={idx} className="mr-1 mb-1 inline-flex items-center bg-muted rounded pr-1.5 py-0.5 text-xs">
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The class name pr-1.5 (padding-right) is used here, which aligns with the intention of removing left padding. However, consider using pl-1.5 (padding-left) instead, or renaming the class to p-1.5 to apply padding on both sides equally. This might provide a more balanced visual appearance. If the intention is to remove padding on the left, it would be more explicit to use pl-0 to remove the padding left, and pr-1.5 to keep the padding right.

 <span key={idx} className="mr-1 mb-1 inline-flex items-center bg-muted rounded pl-0 pr-1.5 py-0.5 text-xs">

<Tag className="h-3 w-3 mr-1" />
{labelName}
</span>
Expand Down