Skip to content

Add additional citations #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brian-rose merged 6 commits into from
Dec 10, 2025
Merged

Add additional citations #565

brian-rose merged 6 commits into from
Dec 10, 2025

Conversation

@kafitzgerald
Copy link
Contributor

@kafitzgerald kafitzgerald commented Nov 26, 2025 •
edited
Loading

Adds additional citations for Jupyter projects, Dask, netCDF, and the CF conventions.

Closes #546 (possibly?)

@review-notebook-app
Copy link

review-notebook-app bot commented Nov 26, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Nov 26, 2025 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: a3a1f54
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/565

@kafitzgerald kafitzgerald marked this pull request as ready for review November 26, 2025 19:21
@kafitzgerald kafitzgerald requested a review from a team as a code owner November 26, 2025 19:21
@kafitzgerald kafitzgerald requested review from brian-rose and clyne and removed request for a team November 26, 2025 19:21
@r-ford
Copy link
Member

r-ford commented Dec 8, 2025

The citations are rendering as narrative instead of parenthetical, but it looks like enclosing the DOIs in square brackets could fix it.

image

@kafitzgerald
Copy link
Contributor Author

kafitzgerald commented Dec 8, 2025

The citations are rendering as narrative instead of parenthetical, but it looks like enclosing the DOIs in square brackets could fix it.

Good catch! Not sure how I missed that.

Fixed and addressed the minor merge conflict.

brian-rose
brian-rose requested changes Dec 9, 2025
View reviewed changes
Copy link
Member

@brian-rose brian-rose left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and yes I agree this should close #546!

Just a few minor edits here.

kafitzgerald and others added 2 commits December 9, 2025 16:21
brian-rose
brian-rose approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@brian-rose brian-rose merged commit 91b2219 into ProjectPythia:main Dec 10, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 10, 2025
@brian-rose @github-actions
Delete preview for pull request \#565
e0fbbec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brian-rose brian-rose brian-rose approved these changes

@clyne clyne Awaiting requested review from clyne clyne is a code owner automatically assigned from ProjectPythia/education

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cite publications for software packages etc wherever possible

3 participants

@kafitzgerald @r-ford @brian-rose