fix: manage frequency startup to avoid race conditions#209
Closed
fix: manage frequency startup to avoid race conditions#209
Conversation
Contributor
|
JoeCap08055
reviewed
Oct 20, 2025
backend/scripts/local-init.cjs
Outdated
| events.map((x) => x.toHuman()) | ||
| ); | ||
| reject(); | ||
| console.log('INFO: MSA transaction completed (possibly already exists)'); |
Contributor
There was a problem hiding this comment.
Under what circumstances would we NOT get an "MSA already exists" dispatch error, but a failed extrinsic could still fail due to the MSA already existing?
JoeCap08055
reviewed
Oct 20, 2025
backend/scripts/local-init.cjs
Outdated
Comment on lines
+64
to
+65
| if (errorDetails.Module && errorDetails.Module.index === '60') { | ||
| console.log('INFO: Provider may already exist for Alice, continuing...'); |
Contributor
There was a problem hiding this comment.
I believe there's a specific error we can check for here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The goal of this PR is to fix errors caused by ensuring the local frequency node, a dependency of SAT, if selected starts before other services are initialized.
Closes #175
Solution
Migrate start-up logic fixes from Gateway into Social App Template
Change summary
{ Module: { index: '60', error: "0x00000000' } }around the default Frequency provider already existing. Error handling has been added to help the startup look cleaner.Steps to Verify
./start.shand/stop.shscripts to confirm they are still workingAdditional details / screenshot
Waiting for local frequency node to start:
Start remaining services, new logging/error handling around provider creation:
Checklist