fix: we were skipping nonces due to JS/Lua array indexing differences#1016
Merged
JoeCap08055 merged 5 commits intomainfrom Feb 3, 2026
Merged
fix: we were skipping nonces due to JS/Lua array indexing differences#1016JoeCap08055 merged 5 commits intomainfrom
JoeCap08055 merged 5 commits intomainfrom
Conversation
shannonwells
reviewed
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The goal of this PR is to fix a bug that appears to have been introduced by a previous PR. The source of the bug stems from the fact that it was assumed the Redis function
incrementNoncewas returning an offset value potentially starting at zero, but because Redis functions are written in Lua (which indexes arrays from1), it was actually returning a minimum value of1.Steps to Verify
Checklist
items that don't apply can be marked NA or deleted