Skip to content

fix: we were skipping nonces due to JS/Lua array indexing differences#1016

Merged
JoeCap08055 merged 5 commits intomainfrom
fix/reserve-next-nonce-bug
Feb 3, 2026
Merged

fix: we were skipping nonces due to JS/Lua array indexing differences#1016
JoeCap08055 merged 5 commits intomainfrom
fix/reserve-next-nonce-bug

Conversation

@JoeCap08055
Copy link
Contributor

Purpose

The goal of this PR is to fix a bug that appears to have been introduced by a previous PR. The source of the bug stems from the fact that it was assumed the Redis function incrementNonce was returning an offset value potentially starting at zero, but because Redis functions are written in Lua (which indexes arrays from 1), it was actually returning a minimum value of 1.

Steps to Verify

  1. Start up any Gateway service that publishes transactions to the chain and submit something
  2. Transaction should appear on-chain (previously, was expiring before being included in a block due to a "nonce hole"

Checklist

items that don't apply can be marked NA or deleted

  • End-to-end tests added

Copy link
Contributor

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@JoeCap08055 JoeCap08055 enabled auto-merge (squash) February 3, 2026 20:54
@JoeCap08055 JoeCap08055 merged commit 0a6abcc into main Feb 3, 2026
17 of 18 checks passed
@JoeCap08055 JoeCap08055 deleted the fix/reserve-next-nonce-bug branch February 3, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants