Skip to content

Conversation

amcsi
Copy link

@amcsi amcsi commented Sep 11, 2025

This makes it so with Cyber Jar the second player also reveals the top 5 cards before the first player deciding how to summon the monsters, rather than the first player not having any knowledge of the second player's cards before deciding how to summon them.

Closes #1231

Video

Here is a video demonstrating that the change I made results in the expected results:
https://www.dropbox.com/scl/fi/0kdv8j524h8xl3hq5nsuv/2025-09-11-20-17-50-Cyber-Jar-fix.mp4?rlkey=nnyrje0kbkaehndkagfnaipn3&dl=0

Sources:

GOAT format: https://www.goatformat.com/rulings1.html
image

Latest TCG text: https://www.db.yugioh-card.com/yugiohdb/card_search.action?ope=2&cid=4913&request_locale=en
Latest OCG text: https://www.db.yugioh-card.com/yugiohdb/card_search.action?ope=2&cid=4913&request_locale=ja
Oldest OCG text can be found in #1231

@amcsi amcsi requested a review from pyrQ as a code owner September 11, 2025 18:39
@amcsi amcsi changed the title Fix "Cyber Jar" Fix Cyber Jar Sep 13, 2025
@NaimSantos NaimSantos self-requested a review September 17, 2025 11:28
Copy link
Contributor

@NaimSantos NaimSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not close #1231. It is introducing an incorrect behavior because that is not how the card works in the OCG, which is what we follow:

『フィールドのモンスターを全て破壊する』処理を行った後、先にターンプレイヤーが、『デッキの上からカードを5枚めくり、その中のレベル4以下で特殊召喚可能なモンスターを全て表側攻撃表示か裏側守備表示で特殊召喚する。残りのめくったカードは全て手札に加える』処理を行います。次にターンプレイヤーから見た相手プレイヤーがこの処理を行います。(お互いのプレイヤーが行う特殊召喚や手札に加える処理は、全て同時に行われたものとして扱います。)

After "destroying all monsters on the field" is performed, the turn player goes first and performs the following process: "flip over the top 5 cards of their deck, and Special Summon all Level 4 or lower monsters among them that can be Special Summoned in face-up Attack Position or face-down Defense Position. Add all remaining flipped cards to their hand." Then, the opponent player, as seen from the turn player's perspective, performs this process. (All Special Summoning and hand actions performed by both players are treated as occurring simultaneously.)

Source: https://db.ygoresources.com/card#4913

The implementation of GOAT specific interactions, when possible via script, is done by adding that modified version to the GOAT subdirectory. Change this pull request to match that.

@amcsi
Copy link
Author

amcsi commented Sep 17, 2025

@NaimSantos apologies, as I do not speak Japanese.

Would it not be appropriate to apply this change to all of TCG? Not sure if that's possible.
Otherwise, I'll make sure to apply this change only for GOAT format.

@NaimSantos
Copy link
Contributor

@NaimSantos apologies, as I do not speak Japanese.

Would it not be appropriate to apply this change to all of TCG? Not sure if that's possible. Otherwise, I'll make sure to apply this change only for GOAT format.

We do not apply individual TCG rulings for non-GOAT format. We apply only the OCG rulings

@amcsi
Copy link
Author

amcsi commented Sep 17, 2025

@NaimSantos I have done what you asked. Note that the new file ends with a trailing newline, because I saw that the last GOAT card also did the same.
I added a new GOAT file with one number larger than the previous one.
If I understand correctly, the way GOAT cards work in EdoPro is that if you have GOAT format selected in the deck editor, it will offer you to use the GOAT variant of cards in the deck editor. But also it should not allow you to use the modern equivalent of the card anymore; but I don't understand how the game will know that this Cyber Jar is associated with the modern Cyber Jar. Nor how it would know which image to use etc., so I must be missing something.

Unless it reads the second line comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GOAT] Cyber Jar incorrectly does not reveal both players' cards before the first person decides how to summon
2 participants