Course Dragging Fix #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonechen
approved these changes
Dec 12, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a course dragging issue by implementing portal-based rendering for dragged items. The change addresses potential CSS positioning issues (such as transform constraints from parent containers) that can occur during drag operations in the @hello-pangea/dnd library.
Key changes:
- Added portal rendering for dragged items to render them at the document body level
- Refactored the render logic to conditionally use
createPortalwhen items are being dragged
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,4 @@ | |||
| import { createPortal } from "react-dom"; | |||
There was a problem hiding this comment.
The import statement has unnecessary leading whitespace. Remove the extra indentation to maintain consistent formatting with the rest of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.