Skip to content

Fixed Planner Resizing and Semester Block placeholder text #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mirmirmirr merged 3 commits into from
Nov 20, 2025
Merged

Fixed Planner Resizing and Semester Block placeholder text #73

mirmirmirr merged 3 commits into from
Nov 20, 2025

Conversation

@ccheung777
Copy link

@ccheung777 ccheung777 commented Nov 18, 2025

This pull request holds changes to Planner.tsx and PlannerCourseHolder.tsx

Changes made to PlannerCourseHolder.tsx

  • Changed the placeholder text from Drag a course here to add it to this semester to Drag a course from the Toolbox
  • This makes it clear to the user that they must have a course in Toolbox before starting to plan their semesters

Changes made to Planner.tsx

  • The page routes to /planner when < 1024 px which properly resizes when jumping from Planner to Courses pages
  • The page automatically navigates to / which is Homepage when ≥ 1024 px

@ccheung777
Update Semester Block placeholder text
6e4fe2c 
Changed the placeholder text  in PlannerCourseHolder to clarify dragging courses from the Toolbox. Added spacing in Planner.tsx to improve layout between semester components (Prettier Write)
@ccheung777
Redirect desktop users from Planner page
b60fde3 
Added a useEffect hook to redirect users to the home page if they access the Planner page from a desktop device. This ensures the Planner page is only accessible on non-desktop devices.
@ccheung777
Prettier Write
1eba397 
Prettier Write for Planner.tsx
@ccheung777 ccheung777 self-assigned this Nov 18, 2025
@ccheung777 ccheung777 added the desktop for desktop specific issues label Nov 18, 2025
This was linked to issues Nov 18, 2025
Screen does not adjust well to changes in window size #49
Closed
Update planner semester placeholder text #58
Closed
mirmirmirr
mirmirmirr approved these changes Nov 20, 2025
View reviewed changes
Copy link

@mirmirmirr mirmirmirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mirmirmirr mirmirmirr merged commit c7270e6 into main-preview Nov 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirmirmirr mirmirmirr mirmirmirr approved these changes

Assignees

@ccheung777 ccheung777

Labels

desktop for desktop specific issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update planner semester placeholder text Screen does not adjust well to changes in window size

3 participants

@ccheung777 @mirmirmirr