-
Notifications
You must be signed in to change notification settings - Fork 0
State persistence #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thank you git for not working
Fixed the CSS where the semester and its number would be next to each other instead I made it closer to the figma where its the semester on top then the number. Same thing for the type of semester where I put it next to the Semester number. And also moved the classes closer to the right, next time I just need to make it look better and closer to the figma.
Finished the semester block UI and matches the figma.
Added state variables that were previously in Catalog and SearchBar: - searchResults and setSearchResults from Catalog - searchPrompt, setSearchPrompt, showFilter, setShowFilter, filters, and setFilters from SearchBar - Passed all these state variables to the Catalog component
Updated the Catalog component to accept the new props.
Updating the SearchBar catalog to use the props passed from App.tsx through Catalog
Now properly accepts an array of Course Search Results
mirmirmirr
approved these changes
Mar 28, 2025
mirmirmirr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search Bar and State Persistence changes