Skip to content

Conversation

@ramonechen
Copy link
Contributor

What?

It's hard to summarize the changes in this pull request. The frankenstein query has been refactored to make use of the SQLModel ORM, and more SQLModel (Pydantic) models have been added to represent more of the existing tables in our database. On top of that, a small change was made to the course search endpoint to refuse any prompts less than 3 characters in length.

Why?

At the time of writing, another branch, automatic-scraping, is far ahead of this one, except for the last commit in this branch. I would like to merge this branch before inevitably merging automatic-scraping.

How?

I wrote code.

Testing?

Trust me bro.

Anything Else?

Have a good day.

I can't believe this works.

More testing needs to be done to ensure that it works no differently from the original SQLAlchemy text query, but it shows results for now at least.
Added the course_relationship, course_restriction, and professor SQLModel table models to reflect the ones already in our database.

The prereq_nesting and prereq_course tables have been left out for now because I don't know how to implement SQL constraints in SQLModel.
The algorithm now ignores any search prompt less than 3 characters in length.
@ramonechen ramonechen requested a review from jzgom067 March 18, 2025 21:35
Copy link

@jzgom067 jzgom067 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you bro.

@ramonechen ramonechen merged commit 173cb5d into main Mar 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants