Rename deptFilters to subjFilters in course search endpoint
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzgom067
approved these changes
Nov 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR renames the deptFilters query parameter to subjFilters in the /course/search endpoint to align with a previous API change where "departments" were renamed to "subjects" and to better reflect the distinction between subjects and departments in the Student Information System.
Key Changes:
- Updated the query parameter name from
deptFilterstosubjFiltersin the function signature - Updated the reference to the parameter when splitting it into a list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Renames the
deptFiltersquery parameter in the/course/searchendpoint tosubjFilters.Closes #15.
Why?
In our last change to the API, the "departments" filter value in another endpoint was renamed to "subjects". This change keeps naming consistent across the API. On top of that, subjects are different from departments as far as SIS is concerned.
How?
I changed two lines.
Testing?
It works through Postman.
Anything Else?
Please, I just changed two lines.