Initial FastAPI Implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All course data-related endpoints from the old Spring Boot API except for the /all endpoint have been implemented in the course_controller.py file. I've decided to take an approach of using parameterized string queries instead of SQLModel's ORM features. I feel like we just don't have enough endpoints to justify writing queries and database models object-oriented style, but this is subject to change.
An .env file is required to supply the API with the credentials needed to interact with the database. An example .env has been added to demonstrate the file format and required variables.
Created course, course_attribute, and course_seats table models and modified the /api/v1/filter/values/{filter} endpoint to use these models instead of raw string queries.
Placed database models and endpoint controllers into their own folders for organization.
Just because I accidentally modified this file instead of making my own .env.
Just aligning with the FastAPI naming convention.
Before, the schema and tables were being created implicitly (if they didn't already exist) on each start-up of the API. They're now wrapped in a function definition so that it doesn't happen implicitly.
Also used black to format all Python files.
I forgot to checkout the code before running the black check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is the initial implementation of the FastAPI API, based on the existing Spring Boot API.
Why?
Spring Boot is stupid and has way too many nuances to implement even something basic. Spring Boot is very scalable, but not very suitable for the scale we're operating at.
How?
I implemented all of our existing endpoints using Python (FastAPI, SQLModel). The behavior of each endpoint should be completely unchanged from the Spring Boot implementation. Except for the "/api/v1/course/all" endpoint, which has been removed in this implementation.
Testing?
Trust me bro.
Anything Else?
Have a good day.