Open
Conversation
Radwan-Albahrani
left a comment
Radwan-Albahrani
left a comment
There was a problem hiding this comment.
Overall fantastic work. I recommend these above changes. Also, I recommend experimenting with more complex designs once you have the time. It will help you significantly in your app development career. Check out some designs here
lib/main.dart
Outdated
| @@ -1,3 +1,5 @@ | |||
| import 'screens/home_screen.dart'; | |||
| import 'dart:ui'; | |||
lib/widgets/details_row.dart
Outdated
Comment on lines
+7
to
+8
| required this.condetions, | ||
| required this.dgree, |
There was a problem hiding this comment.
both words are mispelled. While thats totally fine you should download the spell checker extension
lib/widgets/details_row.dart
Outdated
| @@ -0,0 +1,60 @@ | |||
| import 'package:flutter/material.dart'; | |||
|
|
|||
| class DetailsRow extends StatelessWidget { | |||
There was a problem hiding this comment.
feel like this should be called a weather card not a details row since it contains only one weather condition
lib/screens/home_screen.dart
Outdated
| width: 40, | ||
| color: Colors.white, | ||
| ) | ||
| ]), |
There was a problem hiding this comment.
commas at the end of everything for better formatting
Suggested change
| ]), | |
| ], | |
| ), |
lib/screens/home_screen.dart
Outdated
| DetailsRow( | ||
| image: Image( | ||
| image: AssetImage("assets/images/wind_4161247.png"), | ||
| width: 145), |
There was a problem hiding this comment.
same here
Suggested change
| width: 145), | |
| width: 145, | |
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.