Open
Conversation
RyamAlmalki
reviewed
Oct 12, 2023
RyamAlmalki
left a comment
RyamAlmalki
left a comment
There was a problem hiding this comment.
Overall, great job Ahmed! I'm very proud of you for completing Task 2.
|
|
||
| class TaskListApp { | ||
| // TODO: Implement Task list app | ||
| class Funcions { |
There was a problem hiding this comment.
Consider using a class name that clearly indicates that these are task functions.
|
|
||
|
|
||
| int ? choice = int.tryParse(stdin.readLineSync() ?? "you did't pick a choice ") ; | ||
| if (choice != "") { |
There was a problem hiding this comment.
When parsing an integer, you should check if the result is null before using it instead of checking if it's an empty string.
if (choice == null) {
print('Invalid input. Please enter a number between 1 and 4.');
continue;
}
| }} | ||
|
|
||
| //Complete Task | ||
| void CompleteTask(int taskID) { |
There was a problem hiding this comment.
it's good practice to use camelCase CompleteTask to completeTask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished task2 after watching ryamm video explanation.