Open
Conversation
Radwan-Albahrani
left a comment
Radwan-Albahrani
left a comment
There was a problem hiding this comment.
Overall fantastic work. As expected. Here are a couple pointers for code organization and some tips on null safety. Other than that, Task is complete!
Comment on lines
+3
to
7
| class Task { | ||
| String title; | ||
|
|
||
| Task(this.title); | ||
| } |
There was a problem hiding this comment.
I would recommend keeping this model in a separate file
| case '1': | ||
| stdout.write('Add a task: '); | ||
| String title = stdin.readLineSync() ?? ''; | ||
| taskList.addTask(title); |
There was a problem hiding this comment.
Needs null checking
Suggested change
| taskList.addTask(title); | |
| if(title.isNotEmpty || title.trim() != "") | |
| { | |
| taskList.addTask(title); | |
| } |
| taskList.viewTasks(); | ||
| stdout.write('what is the number of the task to update? '); | ||
| int updateNum=int.tryParse(stdin.readLineSync() ?? '') ?? -1; | ||
| stdout.write('what is the new title? '); |
| Task(this.title); | ||
| } | ||
|
|
||
| class TaskListApp { |
Comment on lines
+51
to
+57
| print('\nTask List App Menu:'); | ||
| print('1. Add Task'); | ||
| print('2. View Tasks'); | ||
| print('3. Update Task'); | ||
| print('4. Delete Task'); | ||
| print('5. Exit'); | ||
| stdout.write('Enter your choice (1-6): '); |
There was a problem hiding this comment.
Maybe make this into a separate function called "displayMenu()"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it took me a while to know how to use git..
but i think i understand it now :)