feat: add colored Lines Changed stat tile to PR Analytics widget (#2450) - #3496
Open
aaniya22 wants to merge 1 commit into
Open
feat: add colored Lines Changed stat tile to PR Analytics widget (#2450)#3496aaniya22 wants to merge 1 commit into
aaniya22 wants to merge 1 commit into
Conversation
…yanshu-byte-coder#2450) Signed-off-by: aaniya22 <aaniyaatomar@gmail.com>
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Contributor
Author
|
The 2 failing tests (in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Lines Changed" stat tile to the PR Analytics widget showing total additions/deletions across PRs in the selected time range, styled with green/red coloring to match GitHub's diff style.
Closes #2450
Type of Change
What Changed
src/app/api/metrics/prs/route.ts) already fetched and returnedtotalAdditions/totalDeletionsvia GitHub GraphQL — fixed a latenttypeof valuetypo bug found while reviewing this pathPRStat.valuetype insrc/components/PRMetrics.tsxto acceptReactNodeso tiles can render styled content, not just strings/numbers+{additions}and red-{deletions}, matching GitHub's diff coloringHow to Test
+Xin green and-Yin redExpected result: Lines Changed tile renders with correct green/red coloring and accurate numbers across all ranges.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Additional Context
Backend GraphQL fetching for additions/deletions was already implemented; this PR focuses on the frontend tile rendering and a small bugfix in the review-time calculation.