Skip to content

fix: code quality and safety improvements #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: code quality and safety improvements #3326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/consistency-score.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
activeDates: Set<string>,
timeZone = "UTC",
): ConsistencyScoreResult {
const sortedDates = Array.from(activeDates).sort();
const sortedDates = Array.from(activeDates).sort((a, b) => a - b);

Check failure on line 136 in src/lib/consistency-score.ts

View workflow job for this annotation

GitHub Actions / Type check 

The right-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.

Check failure on line 136 in src/lib/consistency-score.ts

View workflow job for this annotation

GitHub Actions / Type check 

The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.
const today = todayInTimezone(timeZone);

const weeklyConsistency = computeWeeklyConsistency(activeDates);
Expand Down
2 changes: 1 addition & 1 deletion src/lib/streak-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
if (key) dayKeys.add(key);
}

return Array.from(dayKeys).sort();
return Array.from(dayKeys).sort((a, b) => a - b);

Check failure on line 23 in src/lib/streak-utils.ts

View workflow job for this annotation

GitHub Actions / Type check 

The right-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.

Check failure on line 23 in src/lib/streak-utils.ts

View workflow job for this annotation

GitHub Actions / Type check 

The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.
}

function getRuns(dates: StreakDate[]): { end: string; length: number }[] {
Expand Down
Loading