fix: implement pending room invitations instead of direct member addition#3240
Open
codecrafted1 wants to merge 5 commits into
Open
fix: implement pending room invitations instead of direct member addition#3240codecrafted1 wants to merge 5 commits into
codecrafted1 wants to merge 5 commits into
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Author
|
please review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates the room invitation flow to prevent users from being added to collaboration rooms immediately after entering their GitHub username.
Changes
createRoomInvitation()helper to create pending room invitations.getPendingInvitation()helper to check for existing pending invitations.room_members.Why?
Previously, inviting a user immediately inserted them into the
room_memberstable, making them a full room member without any confirmation or approval.This change introduces the first step toward a consent-based invitation flow by storing invitations separately instead of granting immediate room access.
🔗 Related Issue
Closes #3239
🏷️ Type of Change
📋 Checklist
Notes
This PR introduces pending room invitations as the backend foundation. Users are no longer added directly to a room when invited.