test: webhook UUID resolution + fix sse.test.ts Set regression (#3129) - #3233
Open
Shan7Usmani wants to merge 1 commit into
Open
test: webhook UUID resolution + fix sse.test.ts Set regression (#3129)#3233Shan7Usmani wants to merge 1 commit into
Shan7Usmani wants to merge 1 commit into
Conversation
- Add 8 tests verifying webhook POST handler resolves githubLogin to database UUID before calling sendSSEEvent (fixes Priyanshu-byte-coder#3129) - Fix sse.test.ts: update sendSSEEvent tests to use Set<Controller> registry pattern instead of plain controller object - Covers acceptance criteria: connection registration, payload routing via database UUIDs, and proper cleanup on socket close
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests verifying the GitHub webhook POST handler resolves githubLogin to the database UUID before calling sendSSEEvent, and fixes a pre-existing regression in sse.test.ts where the sseConnections registry changed to Map<string, Set> but tests still stored plain controller objects.
Changes
Acceptance Criteria (from issue)
Related
Closes #3129