Skip to content

feat(milestones): add milestone tracking with progress visualization #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
desireddymohithreddy0925 wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(milestones): add milestone tracking with progress visualization #3228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d0c4e96
Fix: Kanban board cards disappear when dragged to Done column #2662
Jun 22, 2026
1d00193
feat: add customizable category tags to Goal Tracker (#2647)
Jun 22, 2026
c7706af
test: add unit tests for ssrf-protection utility functions (#2615)
Jun 22, 2026
e0aecb2
Merge branch 'main' into test/ssrf-protection-utilities
desireddymohithreddy0925 Jun 22, 2026
337ec11
Merge branch 'main' into test/ssrf-protection-utilities
desireddymohithreddy0925 Jun 26, 2026
0739201
fix(ci): upgrade pnpm and node versions for e2e and visual regression…
Jun 26, 2026
b2b4e51
feat(milestones): add milestone tracking with progress visualization
Jul 5, 2026
0d89219
fix(ci): downgrade node to v20 and fix pnpm approvedBuilds for v11
Jul 5, 2026
b3598c9
Merge remote-tracking branch 'upstream/main' into feature/milestone-t…
Jul 5, 2026
25d26ca
fix(ci): downgrade pnpm to v9 to bypass strict approve-builds
Jul 5, 2026
13e2c72
fix(ci): restore original upstream ci configuration to fix builds
Jul 5, 2026
7371642
feat(milestones): add milestone tracking with progress visualization
Jul 24, 2026
33d3bad
Merge upstream main to resolve conflicts
Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 74 additions & 59 deletions src/app/api/milestones/[id]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,73 +2,85 @@ import { getServerSession } from "next-auth";
import { authOptions } from "@/lib/auth";
import { supabaseAdmin } from "@/lib/supabase";
import { resolveAppUser } from "@/lib/resolve-user";
import { NextResponse } from "next/server";
import { stripHtml } from "@/lib/sanitize";

export const dynamic = "force-dynamic";

export async function PATCH(
export async function PUT(
req: Request,
{ params }: { params: Promise<{ id: string }> }
) {
const { id } = await params;
const session = await getServerSession(authOptions);
if (!session?.githubId) {
return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
return new Response("Unauthorized", { status: 401 });
}

const user = await resolveAppUser(session.githubId, session.githubLogin);
if (!user) return NextResponse.json({ error: "User not found" }, { status: 404 });
const appUser = await resolveAppUser(session.githubId, session.githubLogin);
if (!appUser) return new Response("User not found", { status: 404 });

let body: unknown;
try {
body = await req.json();
} catch {
return NextResponse.json({ error: "Invalid JSON" }, { status: 400 });
const body = await req.json();
const name = stripHtml(body.name || "").trim();
const description = stripHtml(body.description || "").trim();
const dueDate = body.dueDate || null;
const taskIds = body.taskIds || [];

if (!name) {
return new Response("Name is required", { status: 400 });
}

const { data: existing } = await supabaseAdmin
.from("milestones")
.select("id")
.eq("id", id)
.eq("user_id", appUser.id)
.single();

if (!existing) {
return new Response("Milestone not found", { status: 404 });
}

const { data: milestone, error } = await supabaseAdmin
.from("milestones")
.update({
name,
description,
due_date: dueDate,
updated_at: new Date().toISOString(),
})
.eq("id", id)
.eq("user_id", appUser.id)
.select()
.single();

if (error) throw error;

// First unlink any tasks currently linked to this milestone
const { error: unlinkError } = await supabaseAdmin
.from("tasks")
.update({ milestone_id: null })
.eq("milestone_id", id)
.eq("user_id", appUser.id);
if (unlinkError) throw unlinkError;

// Link the new tasks
if (taskIds.length > 0) {
const { error: linkError } = await supabaseAdmin
.from("tasks")
.update({ milestone_id: id })
.in("id", taskIds)
.eq("user_id", appUser.id);
if (linkError) throw linkError;
}

return new Response(JSON.stringify(milestone), {
status: 200,
headers: { "Content-Type": "application/json" },
});
} catch (err: any) {
return new Response(err.message, { status: 500 });
}

if (typeof body !== "object" || body === null) {
return NextResponse.json({ error: "Invalid request body" }, { status: 400 });
}

const { currentValue } = body as Record<string, unknown>;

if (
typeof currentValue !== "number" ||
!Number.isInteger(currentValue) ||
currentValue < 0
) {
return NextResponse.json(
{ error: "currentValue must be a non-negative integer" },
{ status: 400 }
);
}

const { data: existing } = await supabaseAdmin
.from("milestones")
.select("target_value")
.eq("id", id)
.eq("user_id", user.id)
.single();

if (!existing) {
return NextResponse.json({ error: "Milestone not found" }, { status: 404 });
}

const safeCurrentValue = Math.min(currentValue, existing.target_value);

const { data, error } = await supabaseAdmin
.from("milestones")
.update({ current_value: safeCurrentValue })
.eq("id", id)
.eq("user_id", user.id)
.select()
.single();

if (error) {
return NextResponse.json({ error: "Failed to update milestone" }, { status: 500 });
}

return NextResponse.json({ milestone: data });
}

export async function DELETE(
Expand All @@ -78,21 +90,24 @@ export async function DELETE(
const { id } = await params;
const session = await getServerSession(authOptions);
if (!session?.githubId) {
return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
return new Response("Unauthorized", { status: 401 });
}

const user = await resolveAppUser(session.githubId, session.githubLogin);
if (!user) return NextResponse.json({ error: "User not found" }, { status: 404 });
const appUser = await resolveAppUser(session.githubId, session.githubLogin);
if (!appUser) return new Response("User not found", { status: 404 });

const { error } = await supabaseAdmin
.from("milestones")
.delete()
.eq("id", id)
.eq("user_id", user.id);
.eq("user_id", appUser.id);

if (error) {
return NextResponse.json({ error: "Failed to delete milestone" }, { status: 500 });
return new Response(error.message, { status: 500 });
}

return NextResponse.json({ success: true });
return new Response(JSON.stringify({ success: true }), {
status: 200,
headers: { "Content-Type": "application/json" },
});
}
191 changes: 83 additions & 108 deletions src/app/api/milestones/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,136 +3,111 @@ import { authOptions } from "@/lib/auth";
import { supabaseAdmin } from "@/lib/supabase";
import { resolveAppUser } from "@/lib/resolve-user";
import { stripHtml } from "@/lib/sanitize";
import { NextResponse } from "next/server";

export const dynamic = "force-dynamic";

const MAX_MILESTONES_PER_USER = 20;
const MAX_TITLE_LEN = 100;
const MAX_DESCRIPTION_LEN = 300;
const MAX_UNIT_LEN = 30;
const VALID_CATEGORIES = ["commits", "streak", "projects", "custom"] as const;
type Category = (typeof VALID_CATEGORIES)[number];

export async function GET() {
const session = await getServerSession(authOptions);
if (!session?.githubId) {
return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
return new Response("Unauthorized", { status: 401 });
}

const user = await resolveAppUser(session.githubId, session.githubLogin);
if (!user) return NextResponse.json({ error: "User not found" }, { status: 404 });
const appUser = await resolveAppUser(session.githubId, session.githubLogin);
if (!appUser) {
return new Response("User not found", { status: 404 });
}

const { data, error } = await supabaseAdmin
const { data: milestones, error } = await supabaseAdmin
.from("milestones")
.select("*")
.eq("user_id", user.id)
.order("created_at", { ascending: false })
.limit(MAX_MILESTONES_PER_USER);
.select("id, name, description, due_date")
.eq("user_id", appUser.id)
.order("created_at", { ascending: false });

if (error) {
return NextResponse.json({ error: "Failed to fetch milestones" }, { status: 500 });
return new Response(error.message, { status: 500 });
}

return NextResponse.json({ milestones: data ?? [] });
// Fetch tasks to calculate taskIds and completion status per milestone
const { data: tasks, error: taskError } = await supabaseAdmin
.from("tasks")
.select("id, milestone_id, completed")
.eq("user_id", appUser.id)
.not("milestone_id", "is", null);

if (taskError) {
return new Response(taskError.message, { status: 500 });
}

const result = milestones.map((m) => {
const mTasks = tasks.filter((t) => t.milestone_id === m.id);
return {
id: m.id,
name: m.name,
description: m.description,
dueDate: m.due_date,
taskIds: mTasks.map((t) => t.id),
totalTasks: mTasks.length,
completedTasks: mTasks.filter((t) => t.completed).length,
};
});

return new Response(JSON.stringify(result), {
status: 200,
headers: { "Content-Type": "application/json" },
});
}

export async function POST(req: Request) {
const session = await getServerSession(authOptions);
if (!session?.githubId) {
return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
}

let body: unknown;
try {
body = await req.json();
} catch {
return NextResponse.json({ error: "Invalid JSON" }, { status: 400 });
}

if (typeof body !== "object" || body === null) {
return NextResponse.json({ error: "Invalid request body" }, { status: 400 });
}

const { title, description, targetValue, currentValue, unit, targetDate, category } =
body as Record<string, unknown>;

if (typeof title !== "string" || title.trim().length === 0) {
return NextResponse.json({ error: "title must be a non-empty string" }, { status: 400 });
}
const safeTitle = stripHtml(title).slice(0, MAX_TITLE_LEN);
if (safeTitle.length === 0) {
return NextResponse.json({ error: "title must not be empty" }, { status: 400 });
return new Response("Unauthorized", { status: 401 });
}

const safeDescription =
typeof description === "string"
? stripHtml(description).slice(0, MAX_DESCRIPTION_LEN)
: "";

if (
typeof targetValue !== "number" ||
!Number.isInteger(targetValue) ||
targetValue < 1 ||
targetValue > 1_000_000
) {
return NextResponse.json(
{ error: "targetValue must be an integer between 1 and 1,000,000" },
{ status: 400 }
);
const appUser = await resolveAppUser(session.githubId, session.githubLogin);
if (!appUser) {
return new Response("User not found", { status: 404 });
}

const safeCurrentValue =
typeof currentValue === "number" && Number.isInteger(currentValue) && currentValue >= 0
? Math.min(currentValue, targetValue)
: 0;

const safeUnit =
typeof unit === "string" && unit.trim().length > 0
? unit.trim().slice(0, MAX_UNIT_LEN)
: "units";

if (typeof targetDate !== "string" || isNaN(new Date(targetDate).getTime())) {
return NextResponse.json({ error: "targetDate must be a valid date string" }, { status: 400 });
}

const safeCategory: Category = VALID_CATEGORIES.includes(category as Category)
? (category as Category)
: "custom";

const user = await resolveAppUser(session.githubId, session.githubLogin);
if (!user) return NextResponse.json({ error: "User not found" }, { status: 404 });

const { count } = await supabaseAdmin
.from("milestones")
.select("*", { count: "exact", head: true })
.eq("user_id", user.id);

if ((count ?? 0) >= MAX_MILESTONES_PER_USER) {
return NextResponse.json(
{ error: `You can have at most ${MAX_MILESTONES_PER_USER} milestones.` },
{ status: 400 }
);
}

const { data, error } = await supabaseAdmin
.from("milestones")
.insert({
user_id: user.id,
title: safeTitle,
description: safeDescription,
target_value: targetValue,
current_value: safeCurrentValue,
unit: safeUnit,
target_date: targetDate,
category: safeCategory,
})
.select()
.single();

if (error) {
return NextResponse.json({ error: "Failed to create milestone" }, { status: 500 });
try {
const body = await req.json();
const name = stripHtml(body.name || "").trim();
const description = stripHtml(body.description || "").trim();
const dueDate = body.dueDate || null;
const taskIds = body.taskIds || [];

if (!name) {
return new Response("Name is required", { status: 400 });
}

const { data: milestone, error } = await supabaseAdmin
.from("milestones")
.insert({
user_id: appUser.id,
name,
description,
due_date: dueDate,
})
.select()
.single();

if (error) throw error;

// Link tasks if any
if (taskIds.length > 0) {
const { error: updateError } = await supabaseAdmin
.from("tasks")
.update({ milestone_id: milestone.id })
.in("id", taskIds)
.eq("user_id", appUser.id);

if (updateError) throw updateError;
}

return new Response(JSON.stringify(milestone), {
status: 201,
headers: { "Content-Type": "application/json" },
});
} catch (err: any) {
return new Response(err.message, { status: 500 });
}

return NextResponse.json({ milestone: data }, { status: 201 });
}
Loading
Loading