Skip to content

feat: add Legal Links section to footer - #2607

Closed
yachikadev wants to merge 4 commits into
Priyanshu-byte-coder:mainfrom
yachikadev:feat/legal-links-footer
Closed

feat: add Legal Links section to footer#2607
yachikadev wants to merge 4 commits into
Priyanshu-byte-coder:mainfrom
yachikadev:feat/legal-links-footer

Conversation

@yachikadev

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a new Legal Links section to the site footer as requested in the issue.
The new column includes Privacy Policy, Guidelines, and Documentation links —
making important resources easily accessible to users and contributors.

Changes Made

  • Added LEGAL_LINKS array in src/components/Footer.tsx with three links:
    • Privacy Policy → /privacy-policy
    • Guidelines → Code of Conduct on GitHub
    • Documentation → Development guide on GitHub
  • Added a new Legal Links column in the footer grid
  • Updated grid layout to lg:grid-cols-5 to accommodate the new column
  • Reused existing FooterLink component so styling, hover effects, and
    typography are fully consistent with the rest of the footer

Why this matters

Missing legal links reduce trust and discoverability for first-time users
and open-source contributors. Footer is the standard and most accessible
placement for policy-related links.

Closes #1323

- Added LEGAL_LINKS array with Privacy Policy, Guidelines, and Documentation
- Added new Legal Links column in footer grid
- Updated grid layout from 4 to 5 columns for responsive design
- Matches existing footer styling, typography, and hover effects

Closes Priyanshu-byte-coder#1323
@github-actions github-actions Bot added type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature type:design GSSoC type bonus: UI/design (+10 pts) type:performance GSSoC type bonus: performance (+15 pts) gssoc26 GSSoC 2026 contribution labels Jun 20, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Umbrella-io — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@yachikadev

yachikadev commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Hey! Really sorry for the late PR — my git got stuck while syncing
the branch with remote and it took some time to resolve. Everything
is working fine now. Thanks for your patience!

Could you please add the quality label and other relevant labels
to this PR as they help with GSSoC points!

Also wanted to mention that the visual regression check failure is
not caused by my changes — it was already failing before my PR.

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

CI is failing on this PR. Please fix the TypeScript/test errors before we can merge. Run npm run typecheck and npm test locally to reproduce.

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown

@yachikadev is attempting to deploy a commit to the legitox's projects Team on Vercel.

A member of the Team first needs to authorize it.

@yachikadev

Copy link
Copy Markdown
Contributor Author

Hi! I wanted to explain the situation — my git was stuck and I was
unable to push my changes on time, which caused a 6 hour delay in
submitting this PR. By the time I pushed, someone else had already
submitted a PR for the same issue and it got merged into main.

Due to that merge, my PR is now showing a CI failure because of a
duplicate LEGAL_LINKS declaration conflict — which is not a code
error on my part, but a result of the same feature already being
in main.

Could you please consider giving me credit for this issue since I
had worked on it independently and the only reason for the late
submission was a git issue on my end?

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

New UI/feature PRs are on hold during the code quality sprint — see discussion #2651. PRs for tests, refactoring, bug fixes, docs, and performance are welcome.

@yachikadev
yachikadev marked this pull request as draft July 1, 2026 06:11
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

New feature/UI PRs are on hold during the code-quality sprint — see discussion #2651. We'll revisit after the sprint; tests, refactors, and bug-fix PRs are the priority right now.

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

The Legal Links section already landed on main (see Footer.tsx — LEGAL_LINKS exists), and this diff re-declares the same const, which is a compile error. Closing as already implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Add a Legal Links section in the footer with Privacy Policy, Guidelines, and Documentation pages

2 participants