Download Progress #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional progress indicator for backup downloads Add option to specify filename for output file
Eslint is busting my balls today
|
There, it's passing now |
|
Library code should generally not be writing to stdout. You can instead add this output as an example, which would utilize some progress callback in the library method. |
rom1504
reviewed
Dec 17, 2023
| @@ -34,4 +35,37 @@ module.exports = class Download { | |||
|
|
|||
| return await res.buffer() | |||
| } | |||
|
|
|||
| async #downloadWorldWithProgress () { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional progress indicator for backup downloads
Added option to specify filename for output file