test: fix -Werror=format in test-arg-parser download test#80
Merged
Conversation
common_remote_get_content() returns the HTTP status as long, but the skip-message printf used %d. Format it with %ld so the build does not fail under -Werror=format on the CUDA CI toolchain.
There was a problem hiding this comment.
Pull request overview
Fixes a format-type mismatch in the argument-parser download test.
Changes:
- Uses
%ldto print thelongHTTP status code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Format the HTTP status code in the
test-arg-parserdownload-skip message with%ldinstead of%d.Why
common_remote_get_content()returns the status aslong(std::pair<long, std::vector<char>>). The skip-pathprintfused%d, which fails to build under-Werror=formaton the CUDA CI toolchain:This breaks the
cudabuild job (and cascades the self-hosted GPU/CPU jobs into cancellation) on any branch built onprism, independent of that branch's own changes.How
One-line change:
%d->%ldat the call site. No behavior change.