Fix a typo and two copy-pasted docstrings in the telemetry module - #80
Open
Avicennasis wants to merge 1 commit into
Open
Fix a typo and two copy-pasted docstrings in the telemetry module#80Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
- telemetry/core/service.py: 'Supress' -> 'Suppress' - telemetry/interactive/prompts/identity.py: two docstrings copied from newsletter.py now describe the identity prompt Comments and docstrings only; no functional changes. Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
Avicennasis
requested review from
anuragg1209
and removed request for
a team
September 7, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three comment/docstring fixes, no functional changes.
# Supress warnings-># Suppress warnings(the block comment two lines above already spells it "Suppress")._should_prompt): "Check if the user should be prompted tosubscribe to the newsletter." -> "...toshare anonymous usage analytics." The line is copied fromnewsletter.py; this module is the identity/analytics prompt (kind="identity", title "Share anonymous usage analytics?")._on_done): "Done callback fornewsletterprompt." -> "Done callback foridentityprompt."The matching lines in
prompts/newsletter.pyare correct there and were left untouched. Comments and docstrings only -ruff/pyrightbehaviour is unaffected.