Skip to content

Fix invalid inference config values that were passed down to the model - #378

Merged
safaricd merged 5 commits into
mainfrom
dominik/fix-default-inference-configs
Sep 5, 2026
Merged

Fix invalid inference config values that were passed down to the model#378
safaricd merged 5 commits into
mainfrom
dominik/fix-default-inference-configs

Conversation

@safaricd

@safaricd safaricd commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Change Description

The tabpfn_client.hosted had invalid default inference configs. This PR streamlines them with the API's, in which the API (be it the inference container) decides on the configuration that is used, but the user may still overwrite it.

@safaricd
safaricd requested a review from a team as a code owner September 4, 2026 11:28
@safaricd
safaricd requested review from ggprior and simo-prior and removed request for a team and ggprior September 4, 2026 11:28

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cd81f0f. Configure here.

Comment thread src/tabpfn_client/hosted/estimator.py
ggprior
ggprior previously approved these changes Sep 4, 2026

@ggprior ggprior left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny how such a simple change can cause such churn 🫠

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
safaricd and others added 3 commits September 5, 2026 23:28
Bumps the version, moves the #378 fragment into the CHANGELOG.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This reverts commit 8c35152.
@safaricd
safaricd enabled auto-merge September 5, 2026 21:37
@jmkuebler
jmkuebler self-requested a review September 5, 2026 21:48

@jmkuebler jmkuebler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping

@safaricd
safaricd added this pull request to the merge queue Sep 5, 2026
Merged via the queue into main with commit b43fccf Sep 5, 2026
11 checks passed
@safaricd
safaricd deleted the dominik/fix-default-inference-configs branch September 5, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants