ci: reapprove internal PRs after a push dismisses an approval - #377
ci: reapprove internal PRs after a push dismisses an approval#377ggprior wants to merge 2 commits into
Conversation
Branch protection dismisses approvals on every push. For PRs authored and approved by org members that is pure overhead, so restore the approval automatically, mirroring the workflow in PriorLabs/TabPFN. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
31e33c3 to
e8b0f74
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e8b0f74. Configure here.
| types: [dismissed] | ||
|
|
||
| permissions: | ||
| pull-requests: write |
There was a problem hiding this comment.
Workflow grants write permissions globally
Low Severity
This workflow sets pull-requests: write at the workflow level instead of defaulting to empty permissions and granting write only on the reapprove job. That regresses the repository convention that workflow-level permissions stay empty and each job opts in.
Triggered by learned rule: GHA release workflows: SHA-pin, no interpolation, bot token
Reviewed by Cursor Bugbot for commit e8b0f74. Configure here.


Copies the
reapprove-internal-prsworkflow from PriorLabs/TabPFN verbatim.Branch protection dismisses every approval when new commits are pushed. For PRs whose author and previous approver are both org members, the workflow re-approves the new head automatically. It only acts when the dismissed review was an approval and was dismissed by a push, never when a reviewer dismissed it by hand, and it skips PRs from forks.
Prerequisite: the workflow reads org membership with the
PRIORLABS_ORG_MEMBERSHIP_READ_PATsecret. I could not verify that secret is exposed to this repository. If it is org-level and scoped to selected repos, tabpfn-client has to be added before merging, otherwise the membership step fails and nothing is approved.Labelled "no changelog needed" as a CI-only change.