Separate core and model packages - #30
Closed
adrian-prior wants to merge 1 commit into
Closed
Conversation
|
Hi @adrian-prior ! To make it reviewable, I wonder if stacking the PRs could make sense. For example, one PR that ONLY moves files could be a quick accept even without changing anything, and could alleviate on the rest. WDYT? |
Ofc it would for example edit imports. But I feel that this is 90% of the noise, that we could approve either way and much faster, before taking decisions. |
Collaborator
Author
|
Closed in favor of the stack starting with #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be determined if we would like this refactor, but I think we should consider it at least (see internal Slack for further details).
Split the workspace into
relarena,relarena-core, andtabpfn-rel.Validated with Python 3.11/3.12 tests, package builds, and pre-commit.