Draft
Conversation
the model. The remaining model based operations need to be modified yet for compatibility.
model can only holf adjacency information. Some geometric information is added to model_info file. Reading the data and storing it to model class.
… loop has been added. It supports two model types (0 = innermost, 1 = outermost). More options can be added in future if needed.
…d m3dc1_mfmgen, 2 for .dmg models from sim_meshgen) has been added
…m3dc1_model_getgeometricloop()` for consistency. Also, support to other model types (.txt files) has been added to `m3dc1_model_getgeometricloop()`.
…w it's the boundary type (first wall, domain boundary, or other)
…of edges Added bounds check on assigning boundary type to edges when using dmg model
75b26c1 to
89b871e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
.dmgsupport in M3DC1..dmgand mesh.smb.mesh_modelwhich is the same parameter that is used for regular.txtmodel.model_info. This will be generated by the routine that prepares PUMI model and mesh from Simmetrix model and mesh.SCOREC_DIRinstellar.mk(only available on Stellar for testing). Replace the following block:with
Example STAR Test case (just model and mesh files) is provided in:
/projects/M3DC1/SCOREC/examples/2026_02_18_UpdatedModel_STAR