Open
Conversation
Collaborator
Author
|
@nferraro This currently works and the RMP regression test with |
Collaborator
Author
|
b2a8245 sped things up by ~33%, but still much too slow |
Collaborator
Author
|
It's because I'm storing a field for each filament, which is a very large number. I'm working on a change to store one per real coil. |
Collaborator
Author
|
db5e684 makes the GS solver faster than the original. See top comment for more info. |
Collaborator
Author
|
@sjardin You may be interested in this. |
844e5f3 to
99aead8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the poloidal flux from each (real) PF coil in separate fields, so that they don't need to be recomputed at each time step. This has some awkwardness/hacky coding with respect to the coil currents, since we only save one poloidal field per physical coil, but still save a current per filament, so it needs to get summed up. That could be simplified, but this works as is.
Timing Test for GS solver with resistive wall & PF coils
DIII-D case (18 coils)
Old method: ~168 s
New method: ~100 s [9 s to store, 91 s to iterate]
KSTAR case (74 coils)
Old method: ~191 s
New method: ~87 s [21 s to store, 66 s to iterate]