Open
Conversation
bclyons12
force-pushed
the
split_derived
branch
from
a21497f to
ee4c9a9
Compare
bclyons12
force-pushed
the
split_derived
branch
from
a3014c9 to
fc8a1a2
Compare
1. define_pellet_source before kprad_ionize
- Advances pellet location
- Calculates volume of pellet distribution for normalization
- Reads LP source from file
- Calculate ne and temperatures
- Calculates ne and Te at pellet
- Calculates ablation rate
2. define_transport_coefficients & define_sources before ludefall
- Transport coefficients (only resistivity, kappa, viscosity, and visc_e)
- Sources (density, momentum, & heat that used to be in define_transport_coefficients)
3. derived_quantities after kprad_advect
- Calls define_transport_coefficients again
- Calculates other derived quantities
- Calculates scalar diagnostics (not ablation rate anymore)
bclyons12
force-pushed
the
split_derived
branch
from
fc8a1a2 to
9dc194b
Compare
changliu777
force-pushed
the
master
branch
2 times, most recently
from
844e5f3 to
99aead8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working to split the definition of various quantities into different steps. So far the structure is:
define_pellet_sourcebeforekprad_ionizedefine_transport_coefficients&define_sourcesbeforeludefallderived_quantitiesafterkprad_advectdefine_transport_coefficientsagainTo-do: