Prompt agents to use edit skill#96
Open
samsja wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 90ba4c9. Configure here.
| "Discover its CLI usage with `<skill> --help`." | ||
| ) | ||
| if "edit" in installed_skills: | ||
| skill_lines.append(EDIT_SKILL_PROMPT) |
There was a problem hiding this comment.
Edit prompt without IPython tool
Medium Severity
EDIT_SKILL_PROMPT is appended whenever edit appears in installed_skills, but it instructs agents to call await edit(...), which only works inside the IPython kernel. If RLM_TOOLS omits ipython (e.g. bash,edit), that guidance is injected even though skills are not pre-imported and await cannot run.
Reviewed by Cursor Bugbot for commit 90ba4c9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
Prompt-only change gated on installed skills; no runtime or auth behavior changes.
Overview
When the
editskill is installed, the agent system prompt now includesEDIT_SKILL_PROMPT, telling the model to preferawait edit(path=..., old_str=..., new_str=...)for unique exact string replacements and to fall back to normal Python file I/O otherwise. The text spells out supported kwargs and explicitly forbids wrong parameter names and line-based edit styles.tests/test_prompt.pyextends the prompt test helper with aninstalled_skillsoverride and adds coverage that the edit block appears only wheneditis in the installed skills list.Reviewed by Cursor Bugbot for commit 90ba4c9. Bugbot is set up for automated code reviews on this repo. Configure here.