Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

feat(worker): Ability to partition tasks per GPU#602

Closed
JannikSt wants to merge 3 commits into
developfrom
feature/gpu-partitioning-per-task
Closed

feat(worker): Ability to partition tasks per GPU#602
JannikSt wants to merge 3 commits into
developfrom
feature/gpu-partitioning-per-task

Conversation

@JannikSt
Copy link
Copy Markdown
Member

No description provided.

@JannikSt JannikSt requested a review from Copilot June 26, 2025 08:09

This comment was marked as outdated.

@JannikSt JannikSt requested a review from Copilot June 26, 2025 08:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GPU partitioning support for tasks by extending container naming and orchestration. Key updates include:

  • Adding an optional gpu_index field and GPU suffix parsing in TaskContainer.
  • Updating DockerService to handle multiple container creation and log aggregation per GPU.
  • Adjusting task and container restart logic to support partitioned tasks.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/worker/src/docker/task_container.rs Added gpu_index field and updated parsing to extract GPU suffix from container names.
crates/worker/src/docker/service.rs Implemented new logic to generate container names per GPU, start containers with GPU-specific environment variables, and aggregate container logs.
crates/shared/src/models/task.rs Added partition_by_gpu flag to Task and TaskRequest models.
Comments suppressed due to low confidence (2)

crates/worker/src/docker/task_container.rs:27

  • [nitpick] Consider adding a brief comment explaining the expected container name format and the rationale for checking the GPU suffix to improve code clarity.
            let (config_hash, gpu_index) =

crates/worker/src/docker/service.rs:300

  • [nitpick] Refactor the nested check for gpu_index inside the GPU partitioning block to simplify the conditional logic and improve readability.
                                            let container_gpu = if payload.partition_by_gpu && gpu_index.is_some() {

@JannikSt JannikSt closed this Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants