This repository was archived by the owner on Jan 27, 2026. It is now read-only.
chore: dev setup#592
Merged
Merged
Conversation
…hestrator + validator s3 parsing
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the developer setup documentation and refactors initialization logic for the storage provider across several components. Key changes include:
- Reordering and revising the "Docker Compose Setup" section in the development docs.
- Updating the storage provider initialization in both the validator and orchestrator to handle missing credentials more gracefully.
- Adjusting tests, API routes, and environment configuration to support the new optional storage provider patterns.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/development-setup.md | Reorganizes the Docker Compose setup instructions and worker startup guidance. |
| crates/validator/src/main.rs | Refactors storage provider initialization to match optional bucket and credentials. |
| crates/orchestrator/src/main.rs | Similarly refactors storage provider initialization and wraps it in an Option. |
| crates/orchestrator/src/api/tests/helper.rs | Injects the optional storage provider into test state configurations. |
| crates/orchestrator/src/api/server.rs | Updates AppState and endpoint parameters to reflect the optional storage provider. |
| crates/orchestrator/src/api/routes/storage.rs | Implements early error response for missing storage provider using new syntax. |
| Makefile | Adjusts cargo watch commands to conditionally include the bucket name parameter. |
| .env.example | Updates and expands environment variable definitions with sample values. |
Comments suppressed due to low confidence (2)
crates/validator/src/main.rs:352
- Using panic during storage provider initialization may not be ideal for production scenarios. Consider handling the error in a more graceful manner or enhancing the panic message with additional context.
.unwrap_or_else(|_| panic!("Failed to create GCS storage provider"));
crates/orchestrator/src/main.rs:411
- Similar to the validator, panicking on storage provider initialization failure could be improved. Consider using a more graceful error handling strategy or providing more diagnostic details in the error message.
.unwrap_or_else(|_| panic!("Failed to create GCS storage provider"));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.