Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

chore: dev setup#592

Merged
JannikSt merged 1 commit into
developfrom
chore/dev-setup
Jun 25, 2025
Merged

chore: dev setup#592
JannikSt merged 1 commit into
developfrom
chore/dev-setup

Conversation

@JannikSt
Copy link
Copy Markdown
Member

No description provided.

@JannikSt JannikSt requested a review from Copilot June 25, 2025 11:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the developer setup documentation and refactors initialization logic for the storage provider across several components. Key changes include:

  • Reordering and revising the "Docker Compose Setup" section in the development docs.
  • Updating the storage provider initialization in both the validator and orchestrator to handle missing credentials more gracefully.
  • Adjusting tests, API routes, and environment configuration to support the new optional storage provider patterns.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/development-setup.md Reorganizes the Docker Compose setup instructions and worker startup guidance.
crates/validator/src/main.rs Refactors storage provider initialization to match optional bucket and credentials.
crates/orchestrator/src/main.rs Similarly refactors storage provider initialization and wraps it in an Option.
crates/orchestrator/src/api/tests/helper.rs Injects the optional storage provider into test state configurations.
crates/orchestrator/src/api/server.rs Updates AppState and endpoint parameters to reflect the optional storage provider.
crates/orchestrator/src/api/routes/storage.rs Implements early error response for missing storage provider using new syntax.
Makefile Adjusts cargo watch commands to conditionally include the bucket name parameter.
.env.example Updates and expands environment variable definitions with sample values.
Comments suppressed due to low confidence (2)

crates/validator/src/main.rs:352

  • Using panic during storage provider initialization may not be ideal for production scenarios. Consider handling the error in a more graceful manner or enhancing the panic message with additional context.
                            .unwrap_or_else(|_| panic!("Failed to create GCS storage provider"));

crates/orchestrator/src/main.rs:411

  • Similar to the validator, panicking on storage provider initialization failure could be improved. Consider using a more graceful error handling strategy or providing more diagnostic details in the error message.
                    .unwrap_or_else(|_| panic!("Failed to create GCS storage provider"));

Comment thread docs/development-setup.md
@JannikSt JannikSt merged commit a17f07d into develop Jun 25, 2025
1 check passed
@JannikSt JannikSt deleted the chore/dev-setup branch June 25, 2025 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants