This repository was archived by the owner on Jan 27, 2026. It is now read-only.
fix(validator): check if work info returned by contract is zero#581
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the work info verification by ensuring that work info returned by the contract is valid (i.e., not zero) and updates test cases accordingly.
- Updates tests to include a non-zero work_units value and a new NODE_ADDRESS for better simulation
- Enhances the work info retrieval logic with validity checks and improved error handling
- Introduces the is_valid() method for WorkInfo in the shared contracts module
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/validator/src/validators/synthetic_data/tests/mod.rs | Updates test cases with non-zero work_units and NODE_ADDRESS modifications |
| crates/validator/src/validators/synthetic_data/mod.rs | Adds validity checks using is_valid(), and includes additional debug logging |
| crates/shared/src/web3/contracts/implementations/work_validators/synthetic_data_validator.rs | Defines the is_valid() method to verify work info integrity |
JannikSt
force-pushed
the
fix/invalid-workunit-submission
branch
from
81ff1f3 to
aeff76d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.