This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Release/0.3.7#579
Merged
Merged
Conversation
* fix race condition in discovery sync, decrease heartbeat ttl, increase general auth mw request timeout * increase heartbeat timeout
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the 0.3.7 release by extending timeouts, exposing a new Docker network‐mode flag, adding execution‐time metrics, and introducing grace‐period logic for discovery.
- Increased timeouts and expirations (heartbeat client 5→20s, Redis 60→90s).
- Added a
disable_host_network_modeoption to DockerService/Manager and exposed it in the CLI. - Introduced metrics for status‐update execution time and a 5-minute grace period before ejecting nodes.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/worker/src/operations/heartbeat/service.rs | Increased HTTP client timeout to 20s |
| crates/worker/src/docker/service.rs | Added disable_host_network_mode parameter to DockerService::new |
| crates/worker/src/docker/docker_manager.rs | Integrated disable_host_network_mode into DockerManager |
| crates/worker/src/cli/command.rs | Exposed --disable-host-network-mode flag |
| crates/validator/src/validators/hardware.rs | Switched to sequential node validation to avoid nonce conflicts |
| crates/shared/src/security/auth_signature_middleware.rs | Introduced REQUEST_EXPIRY_SECS constant |
| crates/orchestrator/src/store/domains/heartbeat_store.rs | Extended Redis key expiration from 60s to 90s |
| crates/orchestrator/src/status_update/mod.rs | Injected MetricsContext, recording per-node execution time |
| crates/orchestrator/src/metrics/mod.rs | Added status_update_execution_time histogram and recorder |
| crates/orchestrator/src/main.rs | Passed metrics context to status updater |
| crates/orchestrator/src/discovery/monitor.rs | Added a 5-minute grace period before marking nodes inactive |
| Cargo.toml | Bumped workspace version to 0.3.7 |
Comments suppressed due to low confidence (1)
crates/orchestrator/src/status_update/mod.rs:323
- The new metrics recording for status-update execution time isn’t covered by tests. Consider adding unit or integration tests to assert that
record_status_update_execution_timebehaves as expected.
self.metrics.record_status_update_execution_time(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.