This repository was archived by the owner on Jan 27, 2026. It is now read-only.
imp(general): Orchestrator Discovery Sync, Worker Timeouts#578
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines timeout and expiry settings and enhances discovery logging in the worker and orchestrator components.
- Increased HTTP client timeout and shortened Redis heartbeat TTL for more resilient retries.
- Replaced hardcoded expiry values with a shared constant in the signature middleware.
- Added a 5-minute grace period and extra compute‐spec change logging in the discovery monitor.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/worker/src/operations/heartbeat/service.rs | Increased client timeout from 5 s to 20 s |
| crates/shared/src/security/auth_signature_middleware.rs | Introduced REQUEST_EXPIRY_SECS and replaced hardcoded 10 s |
| crates/orchestrator/src/store/domains/heartbeat_store.rs | Reduced Redis expiry from 180 s to 90 s |
| crates/orchestrator/src/discovery/monitor.rs | Added 5 min grace period before marking nodes inactive and log compute spec changes |
Comments suppressed due to low confidence (2)
crates/shared/src/security/auth_signature_middleware.rs:35
- [nitpick] Add a doc comment explaining the rationale behind the 300 s expiry (e.g., aligning rate limit windows) to clarify its intended usage.
const REQUEST_EXPIRY_SECS: u64 = 300;
crates/orchestrator/src/discovery/monitor.rs:323
- Add unit tests covering both branches of the
should_mark_inactivecheck (immediate ejection vs. grace-period wait) to ensure this logic behaves as intended.
if should_mark_inactive {
JannikSt
added a commit
that referenced
this pull request
Jun 24, 2025
* add additional status update loop metrics (#575) * increase heartbeat timeout (#574) * switch to sequential validation as quickfix for nonce issues (#576) * imp(worker): host nw mode with ability to switch networking config (#577) * host nw mode with ability to switch networking config * imp(general): Orchestrator Discovery Sync, Worker Timeouts (#578) * fix race condition in discovery sync, decrease heartbeat ttl, increase general auth mw request timeout * increase heartbeat timeout * release 0.3.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes small improvements to logs that we're seeing on our testnet run.
Primarily nothing critical, just a way to get rid of some logs.