This repository was archived by the owner on Jan 27, 2026. It is now read-only.
feat: exclude nodes with zero balance from node_groups#573
Merged
Conversation
noot
commented
Jun 23, 2025
JannikSt
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiscoveryNodeindiscovery::chainsync::sync_single_node()sync_single_node, handle the case where the node has zero balance by setting status toNodeStatus::LowBalance(todo: is there a non-zero balance we can set this to?)NodeGroupsPlugin::handle_status_change, dissolve the group if the node has low balance (not sure if this is the intended behaviour)closes #408