Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

imp(orchestrator): node store#562

Merged
JannikSt merged 1 commit into
developfrom
imp/orchestrator-node-store
Jun 23, 2025
Merged

imp(orchestrator): node store#562
JannikSt merged 1 commit into
developfrom
imp/orchestrator-node-store

Conversation

@JannikSt

Copy link
Copy Markdown
Member

No description provided.

@JannikSt JannikSt requested a review from Copilot June 23, 2025 12:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements improvements to the node store functionality in the orchestrator. Key changes include:

  • Removing the from_string method from the OrchestratorNode model.
  • Adding a migration step to convert the node store from JSON to a hash format in main.rs.
  • Enhancing error handling for missing worker P2P identifiers in nodes API endpoints.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
crates/orchestrator/src/models/node.rs Removed the from_string method from the node model.
crates/orchestrator/src/main.rs Introduced migration logic to convert the node store to a hash.
crates/orchestrator/src/api/routes/nodes.rs Updated error handling for missing worker P2P fields using expect and match.
Comments suppressed due to low confidence (1)

crates/orchestrator/src/models/node.rs:65

  • The from_string method is removed from OrchestratorNode. Please ensure this removal is intentional and that no consumer of the API relies on this utility.
    }

Comment thread crates/orchestrator/src/main.rs
Comment thread crates/orchestrator/src/api/routes/nodes.rs
@JannikSt JannikSt merged commit 709ed73 into develop Jun 23, 2025
1 check passed
@JannikSt JannikSt deleted the imp/orchestrator-node-store branch June 25, 2025 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants