This repository was archived by the owner on Jan 27, 2026. It is now read-only.
imp(orchestrator): node store#562
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements improvements to the node store functionality in the orchestrator. Key changes include:
- Removing the from_string method from the OrchestratorNode model.
- Adding a migration step to convert the node store from JSON to a hash format in main.rs.
- Enhancing error handling for missing worker P2P identifiers in nodes API endpoints.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/orchestrator/src/models/node.rs | Removed the from_string method from the node model. |
| crates/orchestrator/src/main.rs | Introduced migration logic to convert the node store to a hash. |
| crates/orchestrator/src/api/routes/nodes.rs | Updated error handling for missing worker P2P fields using expect and match. |
Comments suppressed due to low confidence (1)
crates/orchestrator/src/models/node.rs:65
- The from_string method is removed from OrchestratorNode. Please ensure this removal is intentional and that no consumer of the API relies on this utility.
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.