Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

temp adjust discovery restrictions with new gpu setup#289

Merged
JannikSt merged 2 commits into
developfrom
fix/temp-discovery-restriction-adjustments
Apr 23, 2025
Merged

temp adjust discovery restrictions with new gpu setup#289
JannikSt merged 2 commits into
developfrom
fix/temp-discovery-restriction-adjustments

Conversation

@JannikSt
Copy link
Copy Markdown
Member

No description provided.

@JannikSt JannikSt requested a review from Copilot April 23, 2025 13:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the node registration logic to support an updated GPU setup by refining how compute specifications are updated when a node is already active.

  • Updates the compute_specs handling to separately update the GPU field when provided
  • Introduces a cloned copy of the existing node for compute_specs comparison before proceeding with further actions
Comments suppressed due to low confidence (1)

crates/discovery/src/api/routes/node.rs:48

  • [nitpick] Consider renaming 'existing_clone' to a more descriptive name such as 'updated_node' to better reflect its role in representing the modified node state.
let mut existing_clone = existing_node.node.clone();

Comment thread crates/discovery/src/api/routes/node.rs
@JannikSt JannikSt merged commit fde8983 into develop Apr 23, 2025
1 check passed
JannikSt added a commit that referenced this pull request Apr 27, 2025
* temp adjust discovery restrictions with new gpu setup
@JannikSt JannikSt deleted the fix/temp-discovery-restriction-adjustments branch June 25, 2025 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants