This repository was archived by the owner on Jan 27, 2026. It is now read-only.
temp adjust discovery restrictions with new gpu setup#289
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the node registration logic to support an updated GPU setup by refining how compute specifications are updated when a node is already active.
- Updates the compute_specs handling to separately update the GPU field when provided
- Introduces a cloned copy of the existing node for compute_specs comparison before proceeding with further actions
Comments suppressed due to low confidence (1)
crates/discovery/src/api/routes/node.rs:48
- [nitpick] Consider renaming 'existing_clone' to a more descriptive name such as 'updated_node' to better reflect its role in representing the modified node state.
let mut existing_clone = existing_node.node.clone();
JannikSt
added a commit
that referenced
this pull request
Apr 27, 2025
* temp adjust discovery restrictions with new gpu setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.