This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Release: v.0.2.5#285
Merged
Merged
Conversation
* add miner port check to ensure external port is available
JannikSt
force-pushed
the
release/v0.2.5
branch
from
bd0e51a to
9ebfce7
Compare
* Refactor: use shared dependencies across crates - Solves #99 --------- Co-authored-by: Jannik Straube <info@jannik-straube.de>
JannikSt
force-pushed
the
release/v0.2.5
branch
from
9ebfce7 to
c7248e1
Compare
* Introduce exp. backoff when for container start failures --------- Co-authored-by: JannikSt <JannikSt@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* feat: implement compute node deregistration and stake reclamation - Added `remove_compute_node` method to `PrimeNetworkContract` for deregistering a node on-chain - Added `reclaim_stake` method to allow providers to withdraw their stake - Introduced `Deregister` CLI command to remove a compute node from a pool and reclaim stake - Extended `ComputeNodeOperations` and `ProviderOperations` with corresponding async methods --------- Co-authored-by: Jannik Straube <info@jannik-straube.de>
JannikSt
force-pushed
the
release/v0.2.5
branch
from
c7248e1 to
16c3c18
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the release version to v0.2.5 and introduces several enhancements across the codebase. Key changes include the addition of exponential backoff and failure tracking in Docker service operations, a new Deregister command in the CLI with associated wallet creation logic, and improvements to software checks including a new port availability check and webhook support in node status updates.
Reviewed Changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| worker/src/docker/service.rs | Adds constants and exponential backoff for container restart delays. |
| worker/src/cli/command.rs | Updates software checking and introduces a new Deregister command. |
| worker/src/checks/software/*.rs, worker/src/checks/issue.rs, worker/Cargo.toml | Introduces port availability checks and workspace dependency updates. |
| shared/src/web3/contracts/implementations/prime_network_contract.rs | Adds new contract functions for node removal and stake reclaim. |
| orchestrator/src/node/status_update.rs, orchestrator/src/main.rs | Enhances node status updates with webhook triggering and client timeout. |
| Other Cargo.toml files | Migrates dependencies to workspace versions and bumps package versions. |
Files not reviewed (2)
- Makefile: Language not supported
- orchestrator/Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
orchestrator/src/main.rs:181
- The webhook_urls vector may include empty strings if the input is an empty or comma-separated string with empty elements. Consider filtering out empty strings from the resulting collection.
let webhook_urls = args.webhook_urls.clone().unwrap_or_default().split(',').map(|s| s.to_string()).collect();
orchestrator/src/node/status_update.rs:152
- The usage of Duration in the timeout call may lead to a compile error if Duration is not imported. Ensure that 'use std::time::Duration;' is added to the imports.
.timeout(Duration::from_secs(5)) // Add timeout to prevent hanging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.