This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Release: v0.2.4#279
Merged
Merged
Conversation
33c89fc to
e92efd9
Compare
* add size limit to auth middleware * add timeouts to auth * add timeouts to worker-dest calls * update to use suggested limits * Chore: Issue templates (#270) * add ability to eject nodes (#272) * add ability to ban nodes * fix eth display --------- Signed-off-by: Jannik Straube <info@jannik-straube.de> Co-authored-by: Matthew Di Ferrante <mattdf@users.noreply.github.com>
*use GPU type with highest count * mount specific GPU idx and not all
* add status counts to nodes api on orchestrator
e92efd9 to
348de46
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces version 0.2.4 with a collection of changes that improve provider registration, GPU support, and overall configuration consistency across the codebase. Key changes include:
- Enhanced provider registration flow with staking approval and user confirmation.
- Refactored GPU support by replacing boolean flags with an Option-based GpuSpecs in Docker services, CLI command, and hardware detection.
- Updates to tests, documentation, Cargo.toml version, and CI workflows.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| worker/src/operations/provider.rs | Added provider registration control flow with staking and balance validations. |
| worker/src/docker/service.rs | Replaced boolean has_gpu with Option and updated test configuration values. |
| worker/src/docker/docker_manager.rs | Modified GPU handling to leverage GpuSpecs and support GPU indices for container start. |
| worker/src/cli/command.rs | Updated CLI command to extract GPU specs from node configuration. |
| worker/src/checks/hardware/hardware_check.rs | Adjusted GPU specs collection to handle multiple GPU devices and select a primary GPU. |
| worker/src/checks/hardware/gpu.rs | Refactored GPU detection to return a vector of devices and aggregate GPU indices. |
| validator/src/validators/synthetic_data.rs | Added conditional logic for S3 environment variables in synthetic data tests. |
| shared/src/models/node.rs | Extended GpuSpecs with an indices field and updated testing structures accordingly. |
| orchestrator/src/api/routes/nodes.rs | Enhanced node API to aggregate status counts along with node data. |
| discovery/src/api/routes/node.rs | Updated test fixtures to include GPU indices in the node model. |
| Cargo.toml | Bumped the workspace package version from 0.2.3 to 0.2.4. |
| CONTRIBUTING.md | Revised contributing guidelines and branch workflow instructions. |
| .github/workflows/checks.yml | Modified CI workflow to install and configure Redis properly before running tests. |
Comments suppressed due to low confidence (1)
validator/src/validators/synthetic_data.rs:646
- [nitpick] Consider adding tests for the scenario when both S3 credentials and bucket name are provided to ensure that S3 integration is properly validated, rather than only logging and returning early.
if s3_credentials.is_none() || bucket_name.is_none() {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.