Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Feature: Add basic webhook support for orchestrator changes#276

Merged
JannikSt merged 4 commits into
developfrom
feature/orchestrator-webhooks
Apr 21, 2025
Merged

Feature: Add basic webhook support for orchestrator changes#276
JannikSt merged 4 commits into
developfrom
feature/orchestrator-webhooks

Conversation

@JannikSt
Copy link
Copy Markdown
Member

No description provided.

@JannikSt JannikSt requested review from Copilot and mattdf April 18, 2025 18:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds basic webhook support to the orchestrator by introducing new webhook configuration, updating node status handling to trigger webhooks asynchronously, and integrating the feature into the main application startup.

  • Introduces webhook fields and an HTTP client to NodeStatusUpdater.
  • Adds a new async function to trigger webhook notifications on node status changes.
  • Updates tests and CLI argument parsing to support the new webhook configuration.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
orchestrator/src/node/status_update.rs Adds webhook support with new fields, trigger_webhooks, and logic changes in process_nodes.
orchestrator/src/models/node.rs Implements Display for NodeStatus for better logging/output formatting.
orchestrator/src/main.rs Parses webhook URLs from CLI arguments and passes them to NodeStatusUpdater.
Files not reviewed (1)
  • orchestrator/Dockerfile: Language not supported
Comments suppressed due to low confidence (2)

orchestrator/src/node/status_update.rs:332

  • The tests currently pass an empty webhook vector. Consider adding test cases that configure webhook URLs to ensure the triggering logic is properly exercised.
vec![]

orchestrator/src/node/status_update.rs:150

  • The Duration type is used in the webhook trigger but is not imported. Please add 'use std::time::Duration;' at the top of the file.
.timeout(Duration::from_secs(5)) // Add timeout to prevent hanging

@JannikSt JannikSt force-pushed the feature/orchestrator-webhooks branch from 6f38f3a to c294b1f Compare April 21, 2025 14:18
@JannikSt JannikSt merged commit 6edeaad into develop Apr 21, 2025
1 check passed
JannikSt added a commit that referenced this pull request Apr 21, 2025
)

* add basic webhook support to notify when a node changes status on orchestrator

* update helm chart
@JannikSt JannikSt deleted the feature/orchestrator-webhooks branch June 25, 2025 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants