This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Feature: Add basic webhook support for orchestrator changes#276
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds basic webhook support to the orchestrator by introducing new webhook configuration, updating node status handling to trigger webhooks asynchronously, and integrating the feature into the main application startup.
- Introduces webhook fields and an HTTP client to NodeStatusUpdater.
- Adds a new async function to trigger webhook notifications on node status changes.
- Updates tests and CLI argument parsing to support the new webhook configuration.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| orchestrator/src/node/status_update.rs | Adds webhook support with new fields, trigger_webhooks, and logic changes in process_nodes. |
| orchestrator/src/models/node.rs | Implements Display for NodeStatus for better logging/output formatting. |
| orchestrator/src/main.rs | Parses webhook URLs from CLI arguments and passes them to NodeStatusUpdater. |
Files not reviewed (1)
- orchestrator/Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
orchestrator/src/node/status_update.rs:332
- The tests currently pass an empty webhook vector. Consider adding test cases that configure webhook URLs to ensure the triggering logic is properly exercised.
vec![]
orchestrator/src/node/status_update.rs:150
- The Duration type is used in the webhook trigger but is not imported. Please add 'use std::time::Duration;' at the top of the file.
.timeout(Duration::from_secs(5)) // Add timeout to prevent hanging
6f38f3a to
c294b1f
Compare
mattdf
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.