sandbox allowed domains#712
Open
kcoopermiller wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes sandbox network egress configuration and API request shape; misconfiguration could block or unexpectedly allow outbound traffic for restricted sandboxes.
Overview
Adds egress domain allowlists for restricted (non-VM) sandboxes:
allowed_domainson the SDKSandboxandCreateSandboxRequestmodels (API aliasallowedDomains), plus validation that the list is only used whennetwork_accessis false andvmis false.The Prime CLI gains repeatable
--allowed-domainonsandbox create(wildcards documented), mirrors the same rules before submit, passes the list into create requests, and shows Allowed Domains on create confirmation andsandbox getwhen non-empty.Reviewed by Cursor Bugbot for commit 7e3141f. Bugbot is set up for automated code reviews on this repo. Configure here.