Remove deprecated Hosted Training val config surface#688
Open
zahlmann wants to merge 1 commit into
Open
Conversation
Author
|
Docs note from the sweep: the public Hosted Training docs still show |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff49734cab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ff49734 to
f658886
Compare
f658886 to
1d273ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[val]block fromprime train initvalinprime train configsand let schema validation reject old[val]configsvalpayload and avoid regenerating[val]from legacy run metadataContext
I had Codex do this sweep after Prime support told me
[val]is deprecated and[eval]should be used instead.prime-rlremovedorchestrator.valin PrimeIntellect-ai/prime-rl#2193 and recommends registering validation-style checks as eval environments. This aligns the Prime CLI config surface with[eval]/[[eval.env]].Tests
uv run --package prime pytest packages/prime/tests/test_rl_config.py packages/prime/tests/test_train_cli.py packages/prime/tests/test_rl_api.py -quv run --package prime pytest packages/prime/tests/test_lab_view.py -q -k 'training_config or config_builder_preserves_deprecated_val or train_configs or shared_eval'uv run --package prime ruff check packages/prime/src/prime_cli/commands/rl.py packages/prime/src/prime_cli/api/rl.py packages/prime/src/prime_lab_app/training_config.py packages/prime/tests/test_rl_config.py packages/prime/tests/test_train_cli.py packages/prime/tests/test_lab_view.pyNote
Low Risk
Config-surface removal with tests; run reads may still expose legacy
valConfigonRLRun, but new runs no longer sendval.Overview
Removes the deprecated Hosted Training
[val]block from the user-facing config path so validation-style checks align with[eval]/[[eval.env]].CLI & API: Drops
ValConfig, thevalfield onRLConfig, template comments, run-summary output, andval_configonRLClient.create_run(novalkey in create payloads).RLConfigwithextra="forbid"now rejects TOML that still contains[val].Lab:
training_configno longer maps legacyval_configinto exported TOML; rerun copies omit[val]even when old run metadata had it.Tests lock in: init template and
prime train configsomitval,load_configfails on[val], lab export stripsval_config, and the config builder still surfaces[val]only to produce a clear schema error.Reviewed by Cursor Bugbot for commit 1d273ea. Bugbot is set up for automated code reviews on this repo. Configure here.