Skip to content

add missing tunnel retries#434

Merged
kcoopermiller merged 1 commit into
mainfrom
daniel/tunnel-retry
Mar 12, 2026
Merged

add missing tunnel retries#434
kcoopermiller merged 1 commit into
mainfrom
daniel/tunnel-retry

Conversation

@rasdani

@rasdani rasdani commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

adds retry on a missing time oute exception and distinguishes between idempotent requests similarly to GET vs. POST in sandbox packgage.


Note

Medium Risk
Changes retry behavior for GET/DELETE calls to include timeouts, which can alter client-side failure modes and potentially repeat server work if the endpoint is not truly idempotent.

Overview
Improves tunnel client resiliency by splitting retry behavior by request type.

TunnelClient now keeps timeouts non-retryable for non-idempotent requests (e.g., POST create_tunnel), but retries GET/DELETE operations on httpx.TimeoutException via a new _idempotent_request_with_retry, and routes get_tunnel, list_tunnels, delete_tunnel, and bulk_delete_tunnels through it.

Written by Cursor Bugbot for commit 4b000f0. This will update automatically on new commits. Configure here.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b000f06a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/prime-tunnel/src/prime_tunnel/core/client.py
@rasdani rasdani requested a review from kcoopermiller March 12, 2026 20:51
@kcoopermiller kcoopermiller merged commit b65d944 into main Mar 12, 2026
12 checks passed
@kcoopermiller kcoopermiller deleted the daniel/tunnel-retry branch March 12, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants