chore(deps): bump renderers (offset-tokenizer config-build fallback for Laguna)#2663
Merged
Merged
Conversation
…or Laguna) Bumps the deps/renderers submodule 89ab3f0 (v0.1.8.dev35) -> 35c2407 (v0.1.8.dev37), pulling in PrimeIntellect-ai/renderers#75: apply the config-build fallback to ``_get_offset_tokenizer`` too. #72 only wired the fallback into ``load_tokenizer``; ``_get_offset_tokenizer`` still called ``AutoTokenizer.from_pretrained`` directly to avoid the fastokens shim and so kept hitting HF's RoPE validator on Laguna-family models. Every rollout through a hand-coded renderer (LagunaXS2, Qwen35, ...) crashed with the same KeyError #72 was supposed to fix. Verified end-to-end against poolside/Laguna-XS.2 with reverse-text: two RL steps complete cleanly (reward 0.36 / 0.31, ~100 tok/sample); the run then hits an unrelated single-GPU FSDP OOM on the 256-expert trainer, which is a config-sizing issue, not the renderers bug. Also pulls in renderers#74 (``message_tool_names`` field for per-message tool attribution). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
eexwhyzee
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
deps/rendererssubmodule89ab3f0(v0.1.8.dev35) →35c2407(v0.1.8.dev37), pulling in PrimeIntellect-ai/renderers#75.Why
#2657 bumped renderers to pick up the original Laguna
KeyErrorfallback (PrimeIntellect-ai/renderers#72), but minh kept seeing the same crash on hosted-rl whenever renderers were enabled:Root cause: #72 only wired the
_load_fast_tokenizer_directlyfallback into_load_tokenizer_via_auto(i.e. intoload_tokenizer)._get_offset_tokenizer— the helper hand-coded renderers (LagunaXS2, Qwen35, …) call fromattribute_text_segmentsto get an offset-aware tokenizer — calledAutoTokenizer.from_pretraineddirectly to keep the fastokens patch out of that path, and so bypassed the fallback entirely. That path fires on every rollout for hand-coded renderers, which is why disabling renderers made the symptom go away.PrimeIntellect-ai/renderers#75 routes the offset-tokenizer load through
_load_tokenizer_via_autoinstead. Same vanilla (no-fastokens) path, but the config-build fallback now applies.Also pulls in PrimeIntellect-ai/renderers#74 (
message_tool_namesfield for per-message tool attribution).Verification
Reproduced end-to-end on a single H200 node against
poolside/Laguna-XS.2with thereverse-textenv. Without the fix every rollout failed with theKeyErrorabove; with it, the first two RL steps completed cleanly:The run then OOMed on the trainer side at step 2 (
model.layers.33.mlp.experts.w3FSDP all-gather on a single GPU with 256 experts) — that's a config-sizing issue with the 256-expert Laguna model ondp_shard=1, unrelated to the renderers bug.🤖 Generated with Claude Code
Note
Low Risk
Dependency-only submodule bump with a targeted tokenizer-load bugfix; no prime-rl source changes beyond the pin.
Overview
Advances the
deps/rendererssubmodule from v0.1.8.dev35 to v0.1.8.dev37 (PrimeIntellect-ai/renderers#75 and #74). There is no in-tree application code change beyond the pinned commit.The important fix routes offset-tokenizer loading through the same path as
load_tokenizer, so the existingrope_theta/ config-build fallback applies when hand-coded renderers (e.g. Laguna) load tokenizers forattribute_text_segments. That closes rolloutKeyErrorfailures that still happened after an earlier fallback that only covered the main tokenizer load.Also picks up
message_tool_namesfor per-message tool attribution in renderers.Reviewed by Cursor Bugbot for commit c7e5e0a. Bugbot is set up for automated code reviews on this repo. Configure here.