Skip to content

fix(sft): sync validation iteration to prevent FSDP deadlock #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikasenghaas merged 2 commits into from
May 25, 2026

refactor(sft): inline has_data tensor in eval sync loop

e140a7f
Select commit
Loading
Failed to load commit list.
Merged

fix(sft): sync validation iteration to prevent FSDP deadlock #2636

refactor(sft): inline has_data tensor in eval sync loop
e140a7f
Select commit
Loading
Failed to load commit list.
Cursor / Cursor Bugbot succeeded May 25, 2026 in 52s

Bugbot Review

Bugbot Analysis Progress (54s elapsed)

✅ Gathered PR context (2s)
✅ Completed bug detection (52s)
✅ Posted analysis results (0s)

Final Result: Bugbot completed review - no issues found! ✅

Request ID: serverGenReqId_31933a10-1295-4e51-a635-523af6c224fd

Details

View more details on Cursor