Match & link CTeamAiMgr - #519
Merged
Merged
Conversation
Report for GM8E01_48 (ecb33dd - 71f82a1)No changesReport for GM8E01_00 (ecb33dd - 71f82a1)📈 Linked code: 46.01% (+0.37%, +14712 bytes) No changesReport for GM8P01_00 (ecb33dd - 71f82a1)📈 Matched code: 69.22% (+0.24%, +9380 bytes) ✅ 26 new matches
Report for GM8J01_00 (ecb33dd - 71f82a1)No changesReport for GM8E01_02 (ecb33dd - 71f82a1)No changesReport for GM8E01_01 (ecb33dd - 71f82a1)📈 Linked code: 42.09% (+0.37%, +14712 bytes) No changes |
| x0_allocator.allocate(newData, newCapacity); | ||
| long atIdx = at - begin(); | ||
| #if VERSION >= VERSION_GM8P_00 && VERSION != VERSION_GM8E_02 | ||
| T* const newItems = newData; |
Collaborator
There was a problem hiding this comment.
bot:
This was an under-explained MWCC register-allocation workaround. I tested roughly 60 alternatives, including direct indexing, pointer/iterator destinations, normal copy helpers, declaration/loop order, and returning the allocation from a helper. None preserved both PAL insertions and both affected USA02 bodies. The const alias gives PAL's TUniqueId/CTeamAiRole insertions 100%/100%; removing it gives 98.89706%/98.56115%. Applying const to USA02 worsens the original float-vector comparison from 93.171425% to 92.171425%, and FishCloud's modifier vector from 95.40659% to 94.63736%.
I retained the explicit qualifier with a short explanation rather than hiding it in a helper. A cleaner natural expression remains unresolved. In 3cc022a I also removed the unsupported USA02 destructor exception: plain >= preserves its generated object exactly. All six configured builds and complete DOL/REL hashes pass; PAL and USA02 regression reports are empty. Audit evidence.
Collaborator
There was a problem hiding this comment.
Follow-up in 71f82a1: the destructor guard is now removed entirely. The initial implicit test kept TypesMatch before Think, which moved PAL's destructor/vtable into TypesMatch.cpp. Moving the cast declaration after Think lets MWCC generate both in CTeamAiMgr with exact PAL code/data/relocations and no version condition. All six full builds/hashes pass; all 4,138 generated objects retain allocated bytes and relocations, with zero function regressions. The vector qualifier remains a separate unresolved item. Updated evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.