Skip to content

Update to Font Awesome 4.1 - more complexity in the generator scripts#21

Open
zliw wants to merge 14 commits intoPrideChung:masterfrom
zliw:master
Open

Update to Font Awesome 4.1 - more complexity in the generator scripts#21
zliw wants to merge 14 commits intoPrideChung:masterfrom
zliw:master

Conversation

@zliw
Copy link
Copy Markdown

@zliw zliw commented May 28, 2014

as discussed in #19

@koraktor
Copy link
Copy Markdown

koraktor commented Jun 5, 2014

👍

Any chance this will get released soon?

@PrideChung
Copy link
Copy Markdown
Owner

Sorry for my absence, been busy on my daily job. I finally got myself a small vocation this weekend. I'm going to review this PR, maybe write some test for it, you will see a new release next monday.

PS: Just noticed that Font-Awesome introduced the pied-piper icon in the 4.1 release, I ❤️ those geeks.

@PrideChung
Copy link
Copy Markdown
Owner

The PR changed how FAK works in a certain extent, since now we have Swift compatibility to worry about, I will stick to the old way before I could find a new way to make the syntax look great in Objective-C and Swift. I've updated FAK to 2.1.6 to support font-awesome 4.1, this PR will probably be suspended for a while (Sorry for the hard work).

@zliw
Copy link
Copy Markdown
Author

zliw commented Jun 8, 2014

No worries. I'll keep the fork around, in case there are some parts you can use.

I'm curious about the swift compability part, as I've found no hint yet, that there are changes needed (other than perhaps exposing the static strings in the header files, which also would benefit the Objective-C implementation). But I've only watched some WWDC sessions and not yet tested the language and its bridging to Objective-C. So take that with a grain of salt.

@PrideChung
Copy link
Copy Markdown
Owner

Yes, FAK is Swift compatible by default, but the syntax isn't quite pleasing, now we have to call

let icon = FAKFontAwesome.starIconWithSize(20)

to get an icon.

It would be more "swifty" to use a designated initializer like this

let icon = FAKFontAwesome(glyph: .Star, size: 20)

Swift has a more sanity and powerful enum type, I'd like to take advantage of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants