fix(css): hide globe only on external nav links (target=_blank); rest…#76
Merged
Conversation
…ore all frontmatter page icons
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MkDocs Material navigation styling so external-link globe icons are hidden only for nav links that open in a new tab, while preserving internal page/frontmatter icons.
Changes:
- Replaced broad sidebar SVG-hiding rules with a narrower selector scoped to external nav links using
target="_blank".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes two issues with the Nexus documentation site (
nexus.developers.prescottdata.io):mkdocs buildwas aborting withcustom_dir does not existbecause the emptydocs/overrides/directory wasn't tracked by Git. Added.gitkeepto fix this.site_urlto determine if a link is external. The configuredsite_urlpointed to the old GitHub Pages URL (prescott-data.github.io/nexus-framework) instead of the actual deployed domain, so every internal link was flagged as external and got a globe icon. Fixed by correctingsite_url+ a CSS rule that hides the globe on genuinely external links only (scoped to[target="_blank"]to avoid hiding legitimate frontmatter page icons).Also modernises all three CI workflows to opt into Node.js 24 ahead of the GitHub Actions forced cutover on June 2, 2026.
Type of Change
Changes Made
mkdocs.ymlsite_urlfromprescott-data.github.io/nexus-framework→nexus.developers.prescottdata.io. Root cause of the globe icon regression.docs/overrides/.gitkeepoverrides/directory. Without it, CI checkout omits the folder andmkdocs buildaborts.docs/stylesheets/extra.css.md-nav__link[target="_blank"] .md-nav__icon { display: none }— hides the auto-injected globe icon only on external links, preserving all frontmatter page icons (icon: material/...) on internal links..github/workflows/docs.ymlfeat/doc-site-updateto branch trigger; conditioned Pages deploy tomainonly; addedFORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true..github/workflows/docker-publish.ymlFORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueto existingenvblock..github/workflows/release.ymlFORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueenv block.How to Test
nexus.developers.prescottdata.io/concepts/broker/) — the sidebar should show the page's frontmatter icon (database lock) with no globe icon alongside it::beforeicons (globe, Discord, RSS)Buildjob on this branch passes without thecustom_dir does not existerrorMigration / Breaking Changes
Checklist