feat(work pools): support work pool access #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to deployment_access and workspace_access, adds work_pool_access resource to manage access to work pools. Closes #366 Closes https://linear.app/prefect/issue/PLA-985/add-support-for-work-pool-access
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
force-pushed
the
work-pool-access
branch
from
65a59d4 to
ee71594
Compare
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
mitchnielsen
commented
Feb 28, 2025
| Required: true, | ||
| Description: "The name of the Work Pool", | ||
| }, | ||
| "manage_actor_ids": schema.ListAttribute{ |
There was a problem hiding this comment.
This is all repeated from deployment_access and workspace_access. We can de-duplicate a lot of that code. I'll make a followup issue to do that.
There was a problem hiding this comment.
mitchnielsen
commented
Feb 28, 2025
| @@ -27,7 +27,7 @@ func TestAccDatasource_account_role_defaults(t *testing.T) { | |||
| } | |||
|
|
|||
| // Default account role names - these exist in every account | |||
| defaultAccountRoles := []defaultAccountRole{{"Admin", 42}, {"Member", 12}, {"Owner", 44}} | |||
| defaultAccountRoles := []defaultAccountRole{{"Admin", 43}, {"Member", 12}, {"Owner", 45}} | |||
There was a problem hiding this comment.
Unrelated change, but this drifts from time to time when server-side changes are made.
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
jamiezieziula
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to deployment_access and workspace_access, adds work_pool_access resource to manage access to work pools.
API docs
Closes #366
Closes https://linear.app/prefect/issue/PLA-985/add-support-for-work-pool-access
Summary
Requirements
General
Closes <issue>, if availableDraftstatus is used until ready for reviewCode-level changes
New or updated resource/datasource
make docsfrom source code)- When applicable, provide a link back to the relevant page in the Prefect documentation site.
- Resource example under
examples/resources/prefect_<name>/resource.tf- Import example under
examples/resources/prefect_<name>/import.sh(I noticed we don't have imports for deployment_access or workspace_access, so assuming that was intentional for now - but in the future we can add this if it makes sense)- Datasource example under
examples/data-sources,resources>/prefect_<name>/data-source.tf